Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #22083 - remove config/as_deprecation_whitelist.yaml #401

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Jan 3, 2018

No description provided.

@mmoll mmoll changed the title Refs 22083 - remove config/as_deprecation_whitelist.yaml Refs #22083 - remove config/as_deprecation_whitelist.yaml Jan 3, 2018
@timogoebel
Copy link
Member

Just to make sure: Will this fallback to the whitelist in core, then?

@mmoll
Copy link
Contributor Author

mmoll commented Jan 3, 2018

Yes.

The thing is that the whitelist in core will always be used and plugins are completely whitelisted by default - except they're bring thier own whitelist, which was just an empty file in this case, triggering the deprecation notices to be fatal.

@timogoebel timogoebel merged commit b79a85e into theforeman:develop Jan 3, 2018
@mmoll mmoll deleted the asd branch January 3, 2018 19:54
@timogoebel
Copy link
Member

Merged, danke @mmoll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants