Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23073 - Redundant info on the Highlights #418

Closed
wants to merge 1 commit into from
Closed

Fixes #23073 - Redundant info on the Highlights #418

wants to merge 1 commit into from

Conversation

ik5
Copy link
Contributor

@ik5 ik5 commented Apr 2, 2018

Original:
original disocvery ipaddress

New:
new disocvery ipaddress

@theforeman-bot
Copy link
Member

Issues: #23073

@lzap
Copy link
Member

lzap commented Apr 3, 2018

I think we should rather discuss this in the issue, but let's do it here: I don't think that Foreman should be trying to "explain" puppet facts, lots of puppet fact names are "weird" and I like consistency - the same name is used when puppet reports back in core or when you call facter command manually.

This fact is actually not important item for discovery, we have discovery_bootif which identifies the primary interface and ipaddress is therefore ignored. The fact also seems to be legacy now: https://puppet.com/docs/facter/3.9/core_facts.html#ipaddress

I'd rather kept it as is.

@ik5
Copy link
Contributor Author

ik5 commented Apr 4, 2018

Closing the PR over @lzap comment.

It is a hackish solution, because the data arrives from the DB.

@ik5 ik5 closed this Apr 4, 2018
@lzap
Copy link
Member

lzap commented Apr 4, 2018

Thanks, other UX comments in the document are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants