Fixes #35188 - fix puppet plugin detection for permissions issues #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the discovery detection for puppet plugin presence didn't work
|
Issues: #35188 |
Ron-Lavi
commented
Jul 10, 2022
| @@ -310,7 +310,7 @@ class Engine < ::Rails::Engine | |||
| :edit_discovery_rules, | |||
| :destroy_discovery_rules, | |||
| ] | |||
| if defined?(ForemanPuppet::VERSION) | |||
| if defined?(ForemanPuppet::Engine) | |||
There was a problem hiding this comment.
The Engine should be loaded before the Version constant
|
[test foreman_discovery] |
stejskalleos
approved these changes
Jul 11, 2022
|
Failing test is not relevant, tried locally and it ends green. |
stejskalleos
pushed a commit
to stejskalleos/foreman_discovery
that referenced
this pull request
Jul 11, 2022
…eforeman#573) the discovery detection for puppet plugin presence didn't work (cherry picked from commit ea10b98)
Ron-Lavi
added a commit
that referenced
this pull request
Jul 11, 2022
the discovery detection for puppet plugin presence didn't work (cherry picked from commit ea10b98)
Ron-Lavi
added a commit
to Ron-Lavi/foreman_discovery
that referenced
this pull request
Jan 16, 2023
…eforeman#573) the discovery detection for puppet plugin presence didn't work (cherry picked from commit ea10b98)
Ron-Lavi
added a commit
that referenced
this pull request
Jan 16, 2023
the discovery detection for puppet plugin presence didn't work (cherry picked from commit ea10b98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the discovery detection for puppet plugin presence didn't work