Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21.0.4 - DSL settings #588

Merged
merged 2 commits into from Nov 2, 2022
Merged

21.0.4 - DSL settings #588

merged 2 commits into from Nov 2, 2022

Conversation

stejskalleos
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #35551

@evgeni
Copy link
Member

evgeni commented Nov 2, 2022

No idea why tests fail, diff looks good

@stejskalleos
Copy link
Contributor Author

stejskalleos commented Nov 2, 2022 •
edited

No idea why tests fail, diff looks good

I think they are fixed in the develop branch but not in 21.0-stable

Ron-Lavi
Ron-Lavi approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@Ron-Lavi Ron-Lavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tests failures don't seem related

@Ron-Lavi Ron-Lavi merged commit 544bb0b into theforeman:21.0-stable Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ron-Lavi Ron-Lavi Ron-Lavi approved these changes

@evgeni evgeni Awaiting requested review from evgeni

@ares ares Awaiting requested review from ares

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@stejskalleos @theforeman-bot @evgeni @Ron-Lavi