-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #26017 - Skip qpidd under load #319
Conversation
Issues: #26017 |
need to test this in two ways,
Here we expect that qpidd directory is being skipped in backup. Also check restoration after backup to confirm there are no errors. |
Tested the scenarios above on Sat 6.7 snap 13 (+patch and pulled Amit's branch) and seem to work well (/var/lib/qpidd/* collected and restored in case 1 and skipped after three retries in case 2), health check, UI and the content was ok after restore as well. |
if attempt_no == MAX_RETRIES | ||
if attempt_no == MAX_RETRIES && @exclude_qpidd_data | ||
tar_cmd = tar_command(configs, to_exclude.push('/var/lib/qpidd')) | ||
with_spinner('Collecting config files to backup, skipping /var/lib/qpidd') do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As offline discussion, it would be good to have warning instead of spinner showing this information.
end | ||
|
||
# rubocop:disable Metrics/MethodLength | ||
def run | ||
logger.debug("Invoking tar from #{FileUtils.pwd}") | ||
tar_cmd = tar_command | ||
configs, to_exclude = config_files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing configs and to_exclude to tar_command
method, I think it would be good to have options
to tar_command method which will accept extra directories to exclude and append to_exclude list inside tar_command?
I am closing this PR, shall be adding new PR for remaining work. |
The foreman-maintain already had logic to try taking config file backup 3 times. With this PR,