Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #41 - Add capsule clear #68

Closed
wants to merge 1 commit into from
Closed

Fixes #41 - Add capsule clear #68

wants to merge 1 commit into from

Conversation

chris1984
Copy link
Member

No description provided.

@chris1984
Copy link
Member Author

@iNecas other than the style errors since this is my first pr, is there other stuff that is needed I assume?

@iNecas
Copy link
Member

iNecas commented May 31, 2017

I would have some suggestions for refactorings, also related to other procedures, that need similar helpers. For example, stopping/strating services assumes that the services are running at the beginning. In case they were not (such as as part of upgrade scenario), we would unintentionally change the state of the system. I will come to it later this week to suggest some steps for improvement. Stay tuned :)

@chris1984
Copy link
Member Author

Sounds good ty.

@chris1984
Copy link
Member Author

@iNecas When you get a chance, can you do another review of this for the refactor etc.

@iNecas
Copy link
Member

iNecas commented Jun 23, 2017

Sry for the delays @chris1984, so where we are right now is #52 contains a feature that would be very beneficial here (feature(:katello_service).make_stop() {}), that handles correct stopping and staring of the services.
It's waiting on https://github.com/theforeman/foreman_maintain/pull/52/files#r123739959 + #67. Once those are in, we can refactor this one to use those features. I'm sorry it takes a bit more time, but that happens when too many things happen at once. Patience please :)

@chris1984
Copy link
Member Author

@iNecas hey was this still on the roadmap for foreman-maintain or can I close it out and reopen it at a different time? I have ocd with open things that I cant move forward.

@iNecas
Copy link
Member

iNecas commented Oct 16, 2017

The required change was merged in #83 that makes it easier to stop and start the services.

Please have a look at https://github.com/theforeman/foreman_maintain/pull/52/files#diff-d960f2313918737e5fdda6323248d300R1 and update the procedure to:

  1. define confine to be applicable only when appropriate. Would this work for the main server or this is capsule only? You will probably need first to add features/pulp and use that for checking on when the procedure is appropriate

  2. use the make_stop method with block https://github.com/theforeman/foreman_maintain/pull/52/files#diff-d960f2313918737e5fdda6323248d300R9 so that you don't need to stop/start on your own

  3. we moved to redmine in the meantime, please link it to the corresponding redmine issue: I suppose you also have a BZ for it?

  4. another question is how safe this procedure is? Wouldn't this make my capsule unusable? Is there a KCS this would help with?

@chris1984 chris1984 closed this Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants