-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #41 - Add capsule clear #68
Conversation
@iNecas other than the style errors since this is my first pr, is there other stuff that is needed I assume? |
I would have some suggestions for refactorings, also related to other procedures, that need similar helpers. For example, stopping/strating services assumes that the services are running at the beginning. In case they were not (such as as part of upgrade scenario), we would unintentionally change the state of the system. I will come to it later this week to suggest some steps for improvement. Stay tuned :) |
Sounds good ty. |
@iNecas When you get a chance, can you do another review of this for the refactor etc. |
Sry for the delays @chris1984, so where we are right now is #52 contains a feature that would be very beneficial here ( |
@iNecas hey was this still on the roadmap for foreman-maintain or can I close it out and reopen it at a different time? I have ocd with open things that I cant move forward. |
The required change was merged in #83 that makes it easier to stop and start the services. Please have a look at https://github.com/theforeman/foreman_maintain/pull/52/files#diff-d960f2313918737e5fdda6323248d300R1 and update the procedure to:
|
No description provided.