Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20604 - katello-service feature to make services start/stop #83

Merged
merged 1 commit into from Aug 21, 2017

Conversation

kgaikwad
Copy link
Member

No description provided.

@swapab
Copy link
Member

swapab commented Aug 16, 2017

I think we already have a katello feature here #69
I'll rebase the PR and update accordingly.

@kgaikwad You may have a look and see if it meets the purpose?

@kgaikwad
Copy link
Member Author

@swapab ,

I have already added katello-service feature in qpidd PR.
Could you please check PR #52.

We have some queries related to PR #52 that's why I marked it as On-Hold.
To unblock other PRs, I have separated out the code into this new PR.

@kgaikwad
Copy link
Member Author

@swapab ,

One more thing I forgot to mention here is that katello & katello-service are two different things.
katello is plugin and katello-service comes under katello-packaging using which we can perform actions like start/stop/status for few services. So we can't mix these two.

@swapab
Copy link
Member

swapab commented Aug 17, 2017

@kgaikwad Got it.

I think it would be sensible to add katello-service under definitions/services/

@iNecas
Copy link
Member

iNecas commented Aug 21, 2017

Based on scrum call discussion, I'm ok with leaving this one as is and not introducing another namespace for now. Thanks @kgaikwad

@iNecas iNecas merged commit 21b8110 into theforeman:master Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants