Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37149: Include certs tar in backup #796

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fixes #37149: Include certs tar in backup #796

merged 1 commit into from
Feb 12, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Feb 7, 2024

I think this has not worked for a while :/

@ehelms
Copy link
Member Author

ehelms commented Feb 12, 2024

@evgeni Could I bother you for a review?

evgeni
evgeni approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, but why wouldn't it have worked before

Ah, because it's checking foreman version, nit proxy

@ehelms ehelms merged commit 38b9c6c into theforeman:master Feb 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehelms @evgeni