Fixes #33137 - Align with puppet moving to a plugin

[xprazak2]

Since the plan is to have foreman_puppet installed for both new and existing users on 3.0, we do not need to switch policy deploy type just yet.

[ekohl]

Since the plan is to have foreman_puppet installed for both new and existing users on 3.0, we do not need to switch policy deploy type just yet.

Note that we do plan on making it possible, but it'll be experimental.

[ezr-ondrej]

Looks good to me 👍

[xprazak2]

Test are quite red, though passing for me locally. I'll need to take a closer look.

[ezr-ondrej]

This will not work, HG, nor Host exposes puppetclasses and all_puppetclasses.
It has moved to (host || hg).puppet (what is a Facet for puppet)

[ezr-ondrej]

couldn't we let the config to extract the collection? it would give us more flexibility and we could call the object.puppet.collection 🤔

[xprazak2]

We could do that as an emergency solution, it should work with theforeman/foreman_puppet#180

[ezr-ondrej]

This will work once the 1.0 puppet is released

[lzap]

Tests are failing, any plans to merge this?

[xprazak2]

Tests on Jenkins will not pass due to missing dependencies, but GH actions are green, so I think this is ready.

[ezr-ondrej]

Looks ready enough to me 👍

[lzap]

Would be fantastic to have it, I am working on some big refactoring of the plugin and green tests would be very welcome :-)

[xprazak2]

Thanks everyone!

[lzap]

Running tests locally, crossing my fingers! No luck...

Traceback (most recent call last):
	6: from /home/lzap/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb:5:in `<main>'
	5: from /home/lzap/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb:5:in `select'
	4: from /home/lzap/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb:17:in `block in <main>'
	3: from /home/lzap/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb:17:in `require'
	2: from /home/lzap/work/foreman_openscap/test/functional/api/v2/compliance/arf_reports_controller_test.rb:1:in `<top (required)>'
	1: from /home/lzap/work/foreman_openscap/test/functional/api/v2/compliance/arf_reports_controller_test.rb:1:in `require'
/home/lzap/work/foreman_openscap/test/test_plugin_helper.rb:8:in `<top (required)>': uninitialized constant ForemanPuppet (NameError)
rake aborted!

This fails here:

  # Add factories from foreman_ansible
  FactoryBot.definition_file_paths << File.join(ForemanAnsible::Engine.root, '/test/factories')
  FactoryBot.definition_file_paths << File.join(ForemanPuppet::Engine.root, '/test/factories') # HERE
  FactoryBot.reload

I think we need a defined? there? I also see few tests failing, they are all assuming that Puppet plugin is present. I don't have it installed at the moment.

[lzap]

Filed a PR to fix this: #500