Fixes #37477 - Make host links be settings aware

[ofedoren]

No description provided.

[MariaAga]

I suggested the same mistake I did in yesterdays PR 🙃
I meant HOSTS_PATH from import { HOSTS_PATH } from 'foremanReact/routes/Hosts/constants';
HOSTS_PATH is for /new/hosts , for single hosts
getHostsPageUrl is for the experimental index host page

[ofedoren]

But why is that a mistake? The link is built right and we do use it in other places as well:

https://github.com/theforeman/foreman_openscap/blob/master/webpack/components/OpenscapRemediationWizard/ViewSelectedHostsLink.js#L17

https://github.com/theforeman/foreman_openscap/blob/master/webpack/components/OpenscapRemediationWizard/steps/ReviewRemediation.js#L123

[MariaAga]

I dont think getHostsPageUrl is supposed to be used this way anyway

export const getHostsPageUrl = displayNewHostsPage =>
  displayNewHostsPage ? '/new/hosts' : '/hosts';

export const useForemanHostsPageUrl = () => {
  const { displayNewHostsPage } = useForemanSettings();
  return getHostsPageUrl(displayNewHostsPage);
};

useForemanHostsPageUrl is using the setting displayNewHostsPage which is for the index page, and not for the show page

[MariaAga]

Created theforeman/foreman#10174 so foreman context will use the settings for both index and show page for host url

[ofedoren]

Thanks, @MariaAga, I've updated all the links in the wizard to use helpers from core.

[MariaAga]

Please move useForemanHostDetailsPageUrl out so it wont break react by accident

[ofedoren]

It's really... weird that this could break anything :/

Updated.

[MariaAga]

code looks good but I didnt test it 👍