-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #36274 - fix 'Import Puppet Environment' breadcrumb text #354
Conversation
Failing tests are fixed in #353 |
app/views/foreman_puppet/common/_puppetclasses_or_envs_changed.html.erb
Outdated
Show resolved
Hide resolved
Good catch, thanks @Ron-Lavi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#353 merged, please rebase so we can have green tests
breadcrumb text in puppet environment is still set incorrectly as `Lifecycle Environments`
rebased :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, tested locally, and breadcrumb texts are set correctly on puppet environment page.
Then I think we can squash and merge, @stejskalleos ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏 LGTM
breadcrumb text in puppet environment is still set incorrectly as
Lifecycle Environments