Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreman 1.17 updates #297

Merged
merged 8 commits into from
Jan 16, 2018
Merged

Foreman 1.17 updates #297

merged 8 commits into from
Jan 16, 2018

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Dec 24, 2017

No description provided.

@mmoll
Copy link
Contributor Author

mmoll commented Dec 24, 2017

includes GH-295

@iNecas
Copy link
Member

iNecas commented Jan 2, 2018

@mmoll
Copy link
Contributor Author

mmoll commented Jan 2, 2018

this will fail until http://theforeman.org/issues/22065 is resolved.

@adamruzicka
Copy link
Contributor

@adamruzicka
Copy link
Contributor

@mmoll The tests are failing a lot :/

@mmoll
Copy link
Contributor Author

mmoll commented Jan 3, 2018

Could that be this related to GH-298? Or rather the underlying core changes for it?

@adamruzicka
Copy link
Contributor

Doesn't seem to be related in any way

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • a5ef8e8 must be in the format fixes #redmine_number - brief description
  • 536bec7 must be in the format fixes #redmine_number - brief description
  • 2a48962 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • a5ef8e8 must be in the format fixes #redmine_number - brief description
  • 536bec7 must be in the format fixes #redmine_number - brief description
  • 2a48962 must be in the format fixes #redmine_number - brief description
  • af27417 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member

iNecas commented Jan 8, 2018

Running the jenkins, just to see what the issue is now http://ci.theforeman.org/job/test_plugin_pull_request/4483/

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 95d3368 must be in the format fixes #redmine_number - brief description
  • 9944d65 must be in the format fixes #redmine_number - brief description
  • d10d386 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 95d3368 must be in the format fixes #redmine_number - brief description
  • 9944d65 must be in the format fixes #redmine_number - brief description
  • d10d386 must be in the format fixes #redmine_number - brief description
  • 344bd9f must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@mmoll
Copy link
Contributor Author

mmoll commented Jan 9, 2018

down to 295 runs, 546 assertions, 5 failures, 12 errors, 0 skips

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 95d3368 must be in the format fixes #redmine_number - brief description
  • 9944d65 must be in the format fixes #redmine_number - brief description
  • d10d386 must be in the format fixes #redmine_number - brief description
  • 344bd9f must be in the format fixes #redmine_number - brief description
  • 9b9279d must be in the format fixes #redmine_number - brief description
  • 374e403 must be in the format fixes #redmine_number - brief description
  • 3eaa21e must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@mmoll
Copy link
Contributor Author

mmoll commented Jan 10, 2018

http://ci.theforeman.org/job/test_plugin_pull_request/4497/ - the builds that came back are green now, but the hangs are like the ones seen with foreman-tasks tests.

@iNecas
Copy link
Member

iNecas commented Jan 12, 2018

I was able to track the the stuck issue down to https://github.com/theforeman/foreman/blob/8c2262ac78c05dc2b3f723d43ba780b468d27b19/app/jobs/create_rss_notifications.rb#L8 - My guess is some dead-lock with rails loading when running from different thread: the solution will be not to trigger the rss checker in tests, but need to spend some more time on that.

@iNecas
Copy link
Member

iNecas commented Jan 12, 2018

This I guess will be the issue at least in foreman-tasks, still not sure if that affects remote execution as well

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 95d3368 must be in the format fixes #redmine_number - brief description
  • 9944d65 must be in the format fixes #redmine_number - brief description
  • d10d386 must be in the format fixes #redmine_number - brief description
  • 344bd9f must be in the format fixes #redmine_number - brief description
  • 9b9279d must be in the format fixes #redmine_number - brief description
  • 374e403 must be in the format fixes #redmine_number - brief description
  • 3eaa21e must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@mmoll
Copy link
Contributor Author

mmoll commented Jan 16, 2018

@mmoll
Copy link
Contributor Author

mmoll commented Jan 16, 2018

💚

@adamruzicka
Copy link
Contributor

@iNecas anything to add here or can we get this in?

@iNecas
Copy link
Member

iNecas commented Jan 16, 2018

It seems that the Rake aborted is still there (http://ci.theforeman.org/job/test_plugin_pull_request/4512/), but I merged this anyway, as I guess that will still take some time to track this issue down. Latest commit meged as 1d23156. Huge thanks @mmoll and @adamruzicka for helping out with this one!

@iNecas iNecas merged commit 1d23156 into theforeman:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants