Fixes #22168 - Fix ActiveModel::ForbiddenAttributesError #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
Due to a change in Foreman core if we call triggering_params in REX, we receive a Hash instead of ActiveController::Params. Merging a Hash into unpermitted Params leads to the merged Hash not being #permitted? and causing ActiveModel::ForbiddenAttributesError when trying to mass-assign the triggering_params when creating a new job. Related to theforeman/foreman commit 1ccf4df
adamruzicka
force-pushed
the
strong-params
branch
from
64b3281
to
63f26c5
Compare
|
This fixes the issue for me. I'm merging regardless of the CI right now, as there are other things that need to be fixed in tests in #297, but this has influence on usability of the rex itself, therfore pulling it in |
MariaAga
pushed a commit
to MariaAga/foreman_remote_execution
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in Foreman core if we call triggering_params in REX, we receive
a Hash instead of ActiveController::Params. Merging a Hash into unpermitted
Params leads to the merged Hash not being #permitted? and causing
ActiveModel::ForbiddenAttributesError when trying to mass-assign the
triggering_params when creating a new job.
Related to theforeman/foreman commit 1ccf4df