Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #27818 - settings initialization improvement #433

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Fixes #27818 - settings initialization improvement #433

merged 1 commit into from
Oct 4, 2019

Conversation

ezr-ondrej
Copy link
Member

As theforeman/foreman#6902 got merge, we should merge this, to avoid double initialization.

@adamruzicka
Copy link
Contributor

requires foreman version bump

adamruzicka
adamruzicka reviewed Sep 12, 2019
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the missing version bump it works as expected

@ezr-ondrej
Copy link
Member Author

I've bumped the version.

adamruzicka
adamruzicka approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamruzicka adamruzicka merged commit 67b5a69 into theforeman:master Oct 4, 2019
@adamruzicka
Copy link
Contributor

Thank you, @ezr-ondrej !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezr-ondrej @adamruzicka @theforeman-bot