Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #30947 - replace the notice flash type #540

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Fixes #30947 - replace the notice flash type #540

merged 1 commit into from
Oct 1, 2020

Conversation

amirfefer
Copy link
Member

@amirfefer amirfefer commented Oct 1, 2020 •
edited
Loading

The toast notification component supports in warning, success, info and error type
I used the success type here though it can also be info

adamruzicka
adamruzicka approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, ACK

@adamruzicka adamruzicka merged commit aac15f9 into theforeman:master Oct 1, 2020
@adamruzicka
Copy link
Contributor

Thank you @amirfefer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amirfefer @adamruzicka @theforeman-bot