Fixes #25446, #25647, #22832, #22831 - Blank entry, filtering #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ares
requested changes
Mar 5, 2019
| command_name 'play' | ||
| action :play_roles | ||
|
|
||
| success_message _("Ansible roles are being played. Task's UUID:\n%{task_id}") |
There was a problem hiding this comment.
would it be possible to display job invocation id rather? here and in every other output we have here, it's the id that can be found in the response
ofedoren
force-pushed
the
feat-25446-25647-22832-22831
branch
from
2c4c24b
to
09d224d
Compare
|
@ares, changed as you suggested. |
ofedoren
force-pushed
the
feat-25446-25647-22832-22831
branch
2 times, most recently
from
cabad0b
to
b98cb83
Compare
ares
requested changes
Mar 26, 2019
| action :multiple_play_roles | ||
| command_name 'play-hosts' | ||
|
|
||
| success_message _("Ansible roles are being played. Task's id: %{id}") |
| action :multiple_play_roles | ||
| command_name 'play-hostgroups' | ||
|
|
||
| success_message _("Ansible roles are being played. Task's id: %{id}") |
ofedoren
force-pushed
the
feat-25446-25647-22832-22831
branch
from
b98cb83
to
eaf09d1
Compare
|
@ares, done. Thanks! |
ares
approved these changes
Mar 26, 2019
|
Thanks @ofedoren, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires theforeman/foreman_ansible#225 for
assign_rolescommands.