-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 6343 - params from searchables are not wrapped #134
Conversation
Requires theforeman/hammer-cli#122 to work |
@komidore64 would you mind looking at this one? I'm the original author of the idea @mbacovsky implemented and I don't feel right reviewing it. The same for the referenced hammer-cli part, please. |
@mbacovsky note, missing '#' from commit message for redmine to find it |
@domcleal ty, message is fixed |
i'm going to smoke test this and theforeman/hammer-cli#122 with some katello specific commands before acking. thanks. |
@mbacovsky I ran hammer-tests on your branches. There's several breakages:
...but actually it wasn't associated. It sends wrong parameters. I suspect other associating commands are affected as well.
|
seems to work fine for me. i didn't try any of the associated commands that @tstrachota is referring to, tho |
I upadated both PRs. The issues Tomas found were fixed. |
@@ -56,7 +56,7 @@ class CreateCommand < HammerCLIForeman::CreateCommand | |||
failure_message _("Could not create the operating system") | |||
|
|||
def request_params | |||
params = method_options | |||
params = method_options(options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these not calling super
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I'll fix it
ack pending green tests |
[test] |
Fixes 6343 - params from searchables are not wrapped
Options from searchables are now added to params using method_options that should wrap them correctly according to the api docs.