Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15833 - add filtering by env to smart class parameter id resolver #251

Closed
wants to merge 1 commit into from

Conversation

mbacovsky
Copy link
Member

When there is the same class imported from multiple environments
its parameters are listed for each of the respective environments.
This patch is adding filtering by --environemnt-id (--environment)
to sc-param update and info commands.

When there is the same class imported from multiple environments
its parameters are listed for each of the respective environments.
This patch is adding filtering by --environemnt-id (--environment)
to sc-param update and info commands.
@lfisher47
Copy link

Adding environment filter solves the problem, but does it really make sense when the smart class lists are not distinct per environment? Can I really set a default for one environment and not set it for another?

@mbacovsky
Copy link
Member Author

@lfisher47, you are right. After looking more deeper into how params work I'm going to address this on the API level.

@mbacovsky mbacovsky closed this Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants