Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28196 - handle error when empty parameters passed #453

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

rabajaj0509
Copy link
Member

No description provided.

@theforeman-bot
Copy link
Member

@rahulbajaj0509, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

If changing the ticket number used, remember to update the PR title and the commit message (using git commit --amend).


This message was auto-generated by Foreman's prprocessor

Copy link
Member

@mbacovsky mbacovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulbajaj0509 thanks!, LGTM. I did some very basic testing and it fixed the issue for me.

@mbacovsky mbacovsky merged commit 5dfa8ce into theforeman:master Nov 21, 2019
@ofedoren
Copy link
Member

@rahulbajaj0509, @mbacovsky, LGTM as well, but don't we need to do the same for

if @oidc_client_id && @oidc_authorization_endpoint && @oidc_redirect_uri && @oidc_token_endpoint
?

shiramax pushed a commit that referenced this pull request Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants