Fixes #29876 - eliminate auth_type from sessions file #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabajaj0509
commented
May 19, 2020
|
The reason for this PR has been made clear in #516 (comment) 👍 |
ofedoren
approved these changes
May 28, 2020
There was a problem hiding this comment.
LGTM, and after #516 (comment) it makes sense to merge this one. Thanks for all of your effort on this! ❤️
ofedoren
pushed a commit
that referenced
this pull request
May 29, 2020
* Fixes #29876 - eliminate auth_type from sessions file * Refs #29876 - fix test cases for sessions (cherry picked from commit 792c2c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.