Fixes #19510 - Add proxy status and version to info command #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on another PR: |
adiabramovitch
changed the title
ofedoren
requested changes
Aug 10, 2021
There was a problem hiding this comment.
Thanks, @adiabramovitch! Works perfectly, just few rubocop/style nitpicks and then I'll merge it.
adiabramovitch
force-pushed
the
19510
branch
2 times, most recently
from
51659cc
to
efbf564
Compare
ofedoren
reviewed
Aug 10, 2021
| @@ -59,7 +62,7 @@ class DeleteCommand < HammerCLIForeman::DeleteCommand | |||
|
|
|||
| build_options | |||
| end | |||
|
|
|||
ofedoren
approved these changes
Aug 10, 2021
ofedoren
added a commit
that referenced
this pull request
Aug 10, 2021
)" This reverts commit 0c53149.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.