Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minitest, rake and simplecov version #39

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Update minitest, rake and simplecov version #39

merged 2 commits into from
Jun 30, 2023

Conversation

archanaserver
Copy link
Contributor

No description provided.

ofedoren
ofedoren reviewed Jun 9, 2023
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @archanaserver, LGTM, can we add github actions as we did for hammer-cli-foreman-webhooks?

@archanaserver archanaserver mentioned this pull request Jun 13, 2023
Merged
@ofedoren
Copy link
Member

Could you please rebase, so we trigger new GA code?

@archanaserver archanaserver force-pushed the ruby-3.1 branch 7 times, most recently from f1b1f1d to a94f45b Compare June 14, 2023 06:08
@ofedoren
Copy link
Member

Hmm... Could you please check why for Ruby 3 it installs Ruby 3.2 (instead of 3.0) and rake 10.1.1 (instead of latest available)?

@archanaserver archanaserver force-pushed the ruby-3.1 branch 4 times, most recently from 25e0d3a to 0f7667c Compare June 21, 2023 08:17
@archanaserver
Copy link
Contributor Author

Hmm... Could you please check why for Ruby 3 it installs Ruby 3.2 (instead of 3.0) and rake 10.1.1 (instead of latest available)?

@ofedoren can we add the specific ruby version here https://github.com/theforeman/hammer_cli_foreman_openscap/blob/master/.github/workflows/unit_tests.yaml#L49?

ruby-version: 3.0 I'm not sure if this is a right way to do it, WDYT?

@ofedoren
Copy link
Member

The matrix is written right (at least if I compare to other repos) and Ruby version should be specified by each value of the matrix (${{ matrix.ruby }}). The Ruby versions in the matrix are correct as well. The only thing that I don't understand is why the CI for this repo chooses a different Ruby version...

@archanaserver archanaserver force-pushed the ruby-3.1 branch 2 times, most recently from 3aa7e6a to 47824cd Compare June 28, 2023 13:15
@archanaserver archanaserver force-pushed the ruby-3.1 branch 2 times, most recently from eaa6e94 to 0c4b038 Compare June 30, 2023 08:57
@archanaserver archanaserver mentioned this pull request Jun 30, 2023
Closed
@ofedoren
Copy link
Member

Can you please add changes from #41 here?

@archanaserver
Copy link
Contributor Author

Can you please add changes from #41 here?

Yes done! @ofedoren

ofedoren
ofedoren approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @archanaserver!

@ofedoren ofedoren merged commit 7046c61 into theforeman:master Jun 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofedoren ofedoren ofedoren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
EL 9 support
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@archanaserver @ofedoren