Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14651 - Command for Arf report download #5

Merged
merged 1 commit into from Oct 18, 2016

Conversation

xprazak2
Copy link
Contributor

No description provided.

@ares
Copy link
Member

ares commented Sep 30, 2016

Works fine, one observation though, if I don't specify --path I'm getting following error

bin/hammer arf-report download --id 1675
Could not download the Arf report:
  Error: can't dup NilClass

Also it would be great if I got better error message if smart proxy is down, I'm getting this atm

Could not download the Arf report:
  Missing template api/v2/errors/ERF12-1731 [ProxyAPI::ProxyException]: Unable to get XML version of requested report from Smart Proxy ([Errno::ECONNREFUSED]: Connection refused - connect(2) for "foreman.example.tst" port 8443) for proxy https://foreman.example.tst:8443/compliance with {:locale=>[:en], :formats=>[:json], :variants=>[], :handlers=>[:erb, :builder, :raw, :ruby, :rabl]}. Searched in:
    * "/home/ares/Projekty/Zdrojaky/foreman/app/views"
    * "/home/ares/Projekty/Zdrojaky/foreman_discovery/app/views"
    * "/home/ares/Projekty/Zdrojaky/foreman_ansible/app/views"
    * "/home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/views"
    * "/home/ares/Projekty/Zdrojaky/foreman-tasks/app/views"
    * "/home/ares/Projekty/Zdrojaky/foreman_openscap/app/views"
    * "/home/ares/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/apipie-rails-0.3.6/app/views"

although I'm not sure if this should be addressed in foreman_openscap API PR

other than that 👏

@ares
Copy link
Member

ares commented Sep 30, 2016

actually the issue when proxy is down is correct, the only confusing part is about missing template but all other important info is there, so just the empty --path deserves a fix :-)

@xprazak2
Copy link
Contributor Author

xprazak2 commented Oct 3, 2016

I made a small cosmetic change here and updated this as well, you should get a pretty message when proxy is down.

@ares
Copy link
Member

ares commented Oct 3, 2016

RfM 👍

@ares ares merged commit 1d8465f into theforeman:master Oct 18, 2016
@ares
Copy link
Member

ares commented Oct 18, 2016

Thanks @xprazak2, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants