fixes #6158 - only dump defaults for param defaults starting $
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domcleal
force-pushed
the
6158-defaults-variables
branch
3 times, most recently
from
66acf98
to
ea72ae7
Compare
ares
requested changes
Jan 4, 2017
| end | ||
|
|
||
| def default=(default) | ||
| default = nil if ['UNSET', :undef].include?(default) |
There was a problem hiding this comment.
could you extract ['UNSET', :undef] from here and manifest_default= to some constant, e.g. UNSETTING_VALUES so they do not get out of sync?
There was a problem hiding this comment.
Extracted to UNSET_VALUES.
| end | ||
|
|
||
| def manifest_default_params_variable | ||
| manifest_default[1..-1] if manifest_default.to_s.start_with?('$') |
There was a problem hiding this comment.
if dump_default_needed? or rename/alias the method so it makes sense in this context
There was a problem hiding this comment.
Used dump_default_needed?.
Refactors how defaults from the manifest and the defaults dump are stored, keeping them in separate variables and expecting any params with other variables as the default to have `$` prefixes. Only params with a `$` default prefix will be dumped, so any other default string values will not be dumped and are persisted correctly.
domcleal
force-pushed
the
6158-defaults-variables
branch
from
ea72ae7
to
5dae08a
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
PR updated with the suggested changes. |
ares
approved these changes
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors how defaults from the manifest and the defaults dump are
stored, keeping them in separate variables and expecting any params
with other variables as the default to have
$prefixes.Only params with a
$default prefix will be dumped, so any otherdefault string values will not be dumped and are persisted correctly.
Needs theforeman/kafo_parsers#31, I can increase the min kafo_parsers version in the gemspec if/when that's released.