Fix exit() in hook_context and a deprecation warning #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoll
reviewed
Sep 18, 2017
lib/kafo/exit_handler.rb
Outdated
| @@ -34,7 +34,7 @@ def exit(code, &block) | |||
| end | |||
|
|
|||
| def translate_exit_code(code) | |||
| return code if code.is_a?(Fixnum) | |||
| return code if code.is_a?(Integer) || code.is_a?(Fixnum) | |||
There was a problem hiding this comment.
will there be cases, where Integer doesn't suffice?
There was a problem hiding this comment.
Good question. I'm not that familiar with Ruby so I figured this was safer but it's supposed to be a base class so is just Integer sufficient?
|
Thanks @ekohl, works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't know how to write a proper test for this so I'm submitting this as is now. Pointers on how to properly write them would be appreciated.