Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialized to use tito and added spec file #3

Merged
merged 1 commit into from
Feb 18, 2015

Conversation

jlsherrill
Copy link
Contributor

No description provided.

@jlsherrill
Copy link
Contributor Author

@jlsherrill
Copy link
Contributor Author

Also tested on a 2.1 and install with this and it seemed to install with no errors.

Requires(post): /usr/sbin/semodule, /sbin/restorecon, /usr/sbin/setsebool, /usr/sbin/selinuxenabled, /usr/sbin/semanage
Requires(post): policycoreutils-python
Requires(post): selinux-policy-targeted
Requires(postun): /usr/sbin/semodule, /sbin/restorecon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually need Require: foreman-selinux with version specifier (current version + 1 - the removal was not yet merged).

If we have no time to wait, then without version for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this work just fine with the current foreman-selinux ? I'm not sure i get why the version specifier for 1.8 (i presume)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it for elasticsearch port definition which will prevent foreman policy from loading (katello is not the problematic one in this case). See the referenced PR. We will likely bump the release number to 1.8.0-1 to get there.

@lzap
Copy link
Member

lzap commented Jan 29, 2015

LGTM, add the require please

@lzap
Copy link
Member

lzap commented Jan 30, 2015

Let's wait after FOSDEM, we need to bump version of the foreman package to get it working. Katello package can be only installed AFTER foreman-selinux was properly upgraded (and the port was undefined).

@jlsherrill
Copy link
Contributor Author

@lzap good with merging?

@lzap
Copy link
Member

lzap commented Feb 18, 2015

I haven't tested yet.

lzap added a commit that referenced this pull request Feb 18, 2015
Initialized to use tito and added spec file
@lzap lzap merged commit 9e70940 into theforeman:master Feb 18, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants