Fix SCL leaking into Copr SRPM build #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jul 31, 2023
There was a problem hiding this comment.
We already omit it if it's missing:
We also have this code:
obal/obal/data/modules/srpm.py
Lines 100 to 101 in b7d8f1a
I get the impression a literal string False is passed somehow. Perhaps it should really be false since that's how YAML encodes booleans.
The change to using the srpm_build role caused the scl field to become False which was interpreted as a string creating incorrect SRPM names. For example, False-nodejs-sass.
ehelms
commented
Jul 31, 2023
| @@ -3,7 +3,7 @@ | |||
| srpm: | |||
| package: "{{ inventory_dir }}/{{ package_base_dir }}/{{ inventory_hostname }}" | |||
| output: "{{ build_srpm_output_dir }}" | |||
| scl: "{{ scl | default(omit) }}" | |||
| scl: "{{ build_srpm_scl | default(omit) }}" | |||
There was a problem hiding this comment.
Switching the namespaced parameter also seems to have properly fixed it.
|
And now it leaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to using the srpm_build role caused the scl field to become False which was interpreted as a string creating incorrect SRPM names. For example, False-nodejs-sass.