Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25062: set hibernate logging to ERROR #112

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fixes #25062: set hibernate logging to ERROR #112

merged 1 commit into from
Oct 8, 2018

Conversation

akofink
Copy link
Contributor

@akofink akofink commented Oct 8, 2018

See https://hibernate.atlassian.net/browse/HHH-12927. This is required for Candlepin 2.5.7-1.

@ekohl
Copy link
Member

ekohl commented Oct 8, 2018

Will this break on older candlepin versions? I expect not but I don't know it really.

@ekohl ekohl added Bug and removed Not yet reviewed labels Oct 8, 2018
@akofink
Copy link
Contributor Author

akofink commented Oct 8, 2018

I am also not positive. Perhaps @jturel has some insights.

@jturel
Copy link
Contributor

jturel commented Oct 8, 2018

It shouldn't break. We only have 2.5.6 upstream right now so should be easily confirmed :)

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance tests tell me http://localhost:8080/candlepin/status return a HTTP 200 with this change so I guess that works.

@ekohl ekohl merged commit ed0ed83 into theforeman:master Oct 8, 2018
@ekohl
Copy link
Member

ekohl commented Oct 8, 2018

Thanks!

@akofink akofink deleted the 25062 branch October 8, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants