Fixes #13635 - set pulp client cert settings #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ | |||
| $common_name = 'admin', | |||
| ){ | |||
|
|
|||
| $client_cert_name = "${hostname}-pulp-client" | |||
| $client_cert_name = "pulp-client" | |||
There was a problem hiding this comment.
These should be single quotes because there's no variable anymore.
johnpmitsch
force-pushed
the
client_certs
branch
from
b9a4b7e
to
67fe6f2
Compare
|
@ekohl thanks for the feedback, updated |
|
ACK - thanks @johnpmitsch ! |
ehelms
added a commit
that referenced
this pull request
Feb 10, 2016
Fixes #13635 - set pulp client cert settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the hostname from the client cert and key path as that makes it harder to configure in Katello, and setting the pulp client path in the Settings.
Related to Katello/katello#5750