Add support for the range param being an array #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,4 +63,3 @@ subnet <%= @network %> netmask <%= @mask %> { | |||
| next-server <%= @pxeserver %>; | |||
| <% end -%> | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
iirc @ekohl is a big fan of an extra line feed at the end of the file
|
again 👍 for parameter compatibility |
|
👍 |
|
merged, thanks @brandonweeks! |
bastelfreak
pushed a commit
to bastelfreak/puppet-dhcp
that referenced
this pull request
Sep 25, 2017
Normalise MAC addresses to upper case in dhcpd.host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the range param to be passed either as a string or an array. Having multiple range definitions in a pool is supported by dhcpd. This has the added benefit of being API compatible with puppetlabs-dhcp for the range param.