Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow puppetlabs-apache 4.x #709

Merged
merged 1 commit into from
Jan 11, 2019
Merged

allow puppetlabs-apache 4.x #709

merged 1 commit into from
Jan 11, 2019

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Jan 11, 2019

No description provided.

@mmoll
Copy link
Contributor Author

mmoll commented Jan 11, 2019

puppetlabs/puppetlabs-apache#1746 is the only "major" change, AFAICT.

ekohl
ekohl approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also on my list. We'll also need to fix a few other modules so the installer can actually use them though.

@ekohl ekohl merged commit 6ac2958 into theforeman:master Jan 11, 2019
@mmoll mmoll deleted the apache4 branch January 11, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmoll @ekohl @theforeman-bot