Use system packages on EL8 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
May 21, 2019
| $hammer_plugin_prefix = 'tfm-rubygem-hammer_cli_' | ||
| } | ||
| # We use system packages except on EL7 | ||
| if versioncmp($facts['operatingsystemmajrelease'], '8') >= 0 { |
There was a problem hiding this comment.
When you say "except on EL7", maybe we should check for EL7?
Suggested change
| if versioncmp($facts['operatingsystemmajrelease'], '8') >= 0 { | |
| if $facts['operatingsystemmajrelease'] == '7' { |
There was a problem hiding this comment.
(and obviously flip that if/else around)
There was a problem hiding this comment.
I preferred this version because it's a smaller diff if you ignore whitespace, but did think about your suggestion before. I was also worried about strings vs integers in an exact comparison.
ehelms
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested, but here so it can be tested.
cc @ehelms