Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22.1.0 release is missing dep on puppet/mosquitto #751

Closed
jhoblitt opened this issue May 3, 2022 · 3 comments · Fixed by #752
Closed

22.1.0 release is missing dep on puppet/mosquitto #751

jhoblitt opened this issue May 3, 2022 · 3 comments · Fixed by #752
Labels

Comments

@jhoblitt
Copy link
Contributor

jhoblitt commented May 3, 2022

It appears that templates/plugin/remote_execution_ssh.yml.erb is causing foreman_proxy::plugin::remote_execution::mosquitto to be evaluated regardless if it the class is declared in the manifest.

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Could not find declared class mosquitto (file: /etc/puppetlabs/code/environments/IT_3497_foreman3/modules/foreman_proxy/manifests/plugin/remote_execution/mosquitto.pp, line: 36, column: 3) on node foreman.dev.XXX

Which then fails as puppet/mosquitto isn't a declared dependency in metadata.json.

@jhoblitt
Copy link
Contributor Author

jhoblitt commented May 3, 2022

I take that back,foreman_proxy::plugin::remote_execution::script is unconditionally declaring foreman_proxy::plugin::remote_execution::mosquitto.

jhoblitt added a commit to jhoblitt/puppet-foreman_proxy that referenced this issue May 3, 2022
@jhoblitt
Copy link
Contributor Author

jhoblitt commented May 3, 2022

I am at a bit of a loss as to how the acceptance tests were running...

@jhoblitt
Copy link
Contributor Author

jhoblitt commented May 3, 2022

oh... modules are being pulled from fixtures... configure_beaker(modules: :fixtures) do |host|

jhoblitt added a commit to jhoblitt/puppet-foreman_proxy that referenced this issue May 3, 2022
@evgeni evgeni added the Bug label May 3, 2022
evgeni pushed a commit that referenced this issue May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants