Add new dynflow plugin settings #219
Conversation
| @@ -2,4 +2,5 @@ | |||
| class foreman_proxy::plugin::dynflow::params { | |||
| $enabled = true | |||
| $listen_on = 'https' | |||
| $database_path = '/var/spool/foreman-proxy/dynflow/dynflow.sqlite' | |||
There was a problem hiding this comment.
You might want to create this path in both RPM and deb packages first unless it can handle the directory not existing.
It's also worth noting that if this is intended to be persisted indefinitely then it should be /var/lib, and /var/spool should just be used for pending work.
There was a problem hiding this comment.
Yea, the lack of it existing in the packages is what made me realize it wasn't in the installer, will take care of that too.
I would guess it should be persistent since we could otherwise use the in-memory sqlite.
@iNecas Ok to move this to /var/lib?
There was a problem hiding this comment.
Np with me in moving it to /var/lib, @ares objections?
|
Path corrected, and here too https://github.com/theforeman/smart_proxy_dynflow/pull/11/files |
| @@ -17,7 +17,7 @@ | |||
| :ensure => 'file', | |||
| :owner => 'root', | |||
| :mode => '0640', | |||
| :content => /:enabled: https/ | |||
| :content => %r{:enabled: https\n:database: /var/lib/foreman-proxy/dynflow/dynflow.sqlite} | |||
There was a problem hiding this comment.
maybe use verify_exact_contents here?
|
👍 otherwise |
|
ping? |
|
Want theforeman/smart_proxy_dynflow#12 to be merged first so I can include those options too. |
stbenjam
force-pushed
the
fix-dynflow
branch
from
8230620
to
744c720
Compare
stbenjam
changed the title
stbenjam
force-pushed
the
fix-dynflow
branch
from
744c720
to
1f56b45
Compare
| }) | ||
|
|
||
| it 'should generate correct dynflow.yml' do | ||
| verify_exact_contents(catalogue, "#{etc_dir}/foreman-proxy/settings.d/dynflow.yml", [ |
There was a problem hiding this comment.
etc_dir is not defined here. I wonder if we can do that in our spec_helper so we don't have to do it in every spec file.
There was a problem hiding this comment.
as the tests are confined to redhat-7-x86_64 at the beginning of the file, the fixed path would be ok
stbenjam
force-pushed
the
fix-dynflow
branch
from
1f56b45
to
b5dccce
Compare
|
👍 |
|
merged, thanks @stbenjam! |
Creates db axis dynamically for test_plugin_matrix
No description provided.