Fixes #11363 - Smart proxy dynflow console auth #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking: maybe we should make the option configurable + the trusted host check (default to false, but useful for the http users). |
| @@ -1,3 +1,5 @@ | |||
| --- | |||
| :enabled: true | |||
| :database: /var/lib/foreman-proxy/dynflow/dynflow.sqlite | |||
| :dynflow_console_authorize_with_ssl_client: false | |||
There was a problem hiding this comment.
I would go with true by default for dynflow_console_authorize_with_ssl_client
There was a problem hiding this comment.
Also, since it's a dynflow plugin, we can assume, that the console is dynflow as well, so we can shorten the option to console_authorize_with_ssl_client
adamruzicka
force-pushed
the
fix/11363-auth
branch
from
bacafe1
to
cc9580d
Compare
|
Great, thanks! ACK |
|
Thanks @adamruzicka and @stbenjam |
iNecas
added a commit
that referenced
this pull request
Feb 16, 2016
Fixes #11363 - Smart proxy dynflow console auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain HTTP remains freely accessible, connections over HTTPS require a client SSL certificate