Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #19740 - pulp_docker.conf schema 2 #251

Merged
merged 1 commit into from
Jun 8, 2017
Merged

fixes #19740 - pulp_docker.conf schema 2 #251

merged 1 commit into from
Jun 8, 2017

Conversation

thomasmckay
Copy link
Contributor

correctly handle schema 2

To test, sync solr from docker hub then docker pull w/ docker-1.12 or higher

ekohl
ekohl approved these changes Jun 5, 2017
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks correct. I don't know the specifics of docker but it looks like it makes sense and I trust you on it.

@ehelms ehelms merged commit 5b0c981 into theforeman:master Jun 8, 2017
@ekohl
Copy link
Member

ekohl commented Jun 9, 2017

Odd that the tests appear to pass here but now fail in master.

@ekohl ekohl mentioned this pull request Jun 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasmckay @ekohl @ehelms