-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulpcore logging format to include correlation id. #175
Conversation
This looks good to me, just need tests to be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we only have correlation IDs in the API service? Is this also something that should be logged in workers?
According to @daviddavis the workers are passed a correlation id but log it by default, no need for special configuration |
Assuming that you're using the default for LOGGING, it should include the correlation id in the django logs which applies to the workers. This line here is to configure gunicorn to also output the correlation id. |
Ok, that's good. I also don't think content has correlation IDs. Correct? |
That's correct: the content app does not support correlation id. If that's something you all need, I can take a look. |
I don't think so but I would like to make sure this PR covers everything we need. I'd like to avoid doing multiple PRs, each for a single service. |
b06b64e
to
cec9c92
Compare
@ekohl @ehelms @jlsherrill anything else that should be changed for this PR? |
@ekohl okay to merge? |
No description provided.