Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulpcore logging format to include correlation id. #175

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

jjeffers
Copy link
Contributor

No description provided.

@jlsherrill
Copy link
Contributor

This looks good to me, just need tests to be fixed

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we only have correlation IDs in the API service? Is this also something that should be logged in workers?

@jlsherrill
Copy link
Contributor

According to @daviddavis the workers are passed a correlation id but log it by default, no need for special configuration

@daviddavis
Copy link

Do we only have correlation IDs in the API service? Is this also something that should be logged in workers?

Assuming that you're using the default for LOGGING, it should include the correlation id in the django logs which applies to the workers. This line here is to configure gunicorn to also output the correlation id.

@ekohl
Copy link
Member

ekohl commented Mar 15, 2021

Ok, that's good. I also don't think content has correlation IDs. Correct?

@daviddavis
Copy link

That's correct: the content app does not support correlation id. If that's something you all need, I can take a look.

@ekohl
Copy link
Member

ekohl commented Mar 15, 2021

I don't think so but I would like to make sure this PR covers everything we need. I'd like to avoid doing multiple PRs, each for a single service.

@jjeffers
Copy link
Contributor Author

@ekohl @ehelms @jlsherrill anything else that should be changed for this PR?

@jlsherrill
Copy link
Contributor

@ekohl okay to merge?

@ehelms ehelms merged commit 4737d26 into theforeman:master Mar 19, 2021
@wbclark wbclark added the Enhancement New feature or request label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants