Add param for unsafe advisory conflict resolution #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
changed the title
ekohl
requested changes
Jan 31, 2023
m-bucher
force-pushed
the
add_advisory_conflict_resolve_option
branch
from
3bd0d20
to
db7784e
Compare
ekohl
requested changes
Jan 31, 2023
There was a problem hiding this comment.
I should have checked this earlier, but this comes from pulp_rpm so it should also live in pulpcore::plugin::rpm. See 5e2bfd7 for an example of how a plugin-specific config option was added earlier.
In this case there is already some inline content so it probably makes sense to move it to a template. While most templates are ERB, I'd like to move to EPP. In 2e2d3ec I added an EPP template. Note how it uses epp() (with a context) instead of template() and a slightly different context.
m-bucher
force-pushed
the
add_advisory_conflict_resolve_option
branch
from
db7784e
to
c74c3a8
Compare
ekohl
approved these changes
Feb 2, 2023
|
Thanks @ekohl for merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.theforeman.org/t/katello-incoming-and-existing-advisories-have-the-same-id-but-different-timestamps/23954/8