Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CA related files for Puppetserver 5.3.6 #643

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Update CA related files for Puppetserver 5.3.6 #643

merged 1 commit into from
Nov 16, 2018

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Oct 23, 2018

No description provided.

@mmoll
Copy link
Contributor Author

mmoll commented Nov 3, 2018

@ekohl would you prefer this to go in first, or GH-649 and GH-650?

@ekohl
Copy link
Member

ekohl commented Nov 5, 2018

It's fine to merge this first. Is it still WIP like the title says?

@mmoll
Copy link
Contributor Author

mmoll commented Nov 5, 2018

I'll add some tests then it should be ready. I have no idea, if anything in ca.conf should be set differently...

@mmoll mmoll changed the title [WIP] update CA related files for Puppetserver 5.3.6 Update CA related files for Puppetserver 5.3.6 Nov 11, 2018
@mmoll
Copy link
Contributor Author

mmoll commented Nov 11, 2018

This should be ready now, I took the Puppet Labs defaults for the CA settings.

@mmoll
Copy link
Contributor Author

mmoll commented Nov 16, 2018

@ekohl gentle ping ☝️
I even think this could still go into the next 10.x release, at least I think there should be no behavioural change.

@ekohl ekohl merged commit bd645b5 into theforeman:master Nov 16, 2018
@ekohl
Copy link
Member

ekohl commented Nov 16, 2018

Thanks! We just kicked off the pipeline for 1.20.0 but we're planning on a relatively quick 1.20.1 release anyway.

@mmoll mmoll deleted the ps_536 branch November 16, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmoll @ekohl @theforeman-bot