Fixes #25839 - Determine puppetserver version in server.pp #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we store some parameters in the installers answers file that relate to the puppetserver version. This is because we determine them in params.pp which means init.pp has them. The result is that when a user upgrades, their answers need to be reset. Katello has a hook to always do this, Foreman has nothing. By defaulting to undef and moving the the determination into server.pp we can avoid this whole problem.
ehelms
approved these changes
Jan 11, 2019
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we store some parameters in the installers answers file that relate to the puppetserver version. This is because we determine them in params.pp which means init.pp has them. The result is that when a user upgrades, their answers need to be reset. Katello has a hook to always do this, Foreman has nothing.
By defaulting to undef and moving the the determination into server.pp we can avoid this whole problem.