Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fedora 31, drop Fedora 26 #745

Merged
merged 1 commit into from
May 13, 2020
Merged

Add Fedora 31, drop Fedora 26 #745

merged 1 commit into from
May 13, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented May 13, 2020

Fedora 26 is EOL. Fedora 32 is not added since there are no packages available.

@ekohl
Copy link
Member Author

ekohl commented May 13, 2020

Looks like cron is not available, like in the ubuntu images. I've submitted puppetlabs/puppetlabs-stdlib#1108 which can make our code dynamic rather than having to hardcode available providers. For now I've just ensured the package is installed in our acceptance tests.

@mmoll
Copy link
Contributor

mmoll commented May 13, 2020

As it seems, there are no puppetserver RPMs available for F31 currently.

@ekohl
Copy link
Member Author

ekohl commented May 13, 2020

Not entirely sure how to deal with this now. On the one hand, the agent works but on the other, it's not entirely there. We have unsupported_puppetmaster_osfamily but Fedora is not its own family.

@mmoll
Copy link
Contributor

mmoll commented May 13, 2020

Maybe we can just add a puppetserver_supported variable? Then the Ubuntu/focal PR also could go in and we can enable it per OS, once new puppetserver builds are available...

@ekohl
Add Fedora 31, drop Fedora 26
6919e79 
Fedora 26 is EOL. Fedora 32 is not added since there are no packages
available.

Because there are no server packages, a test just for the agent is
added.
@ekohl
Copy link
Member Author

ekohl commented May 13, 2020

So something like this. I added a trivial agent test case to at least test something

@mmoll mmoll merged commit 4c5c2a3 into theforeman:master May 13, 2020
@mmoll
Copy link
Contributor

mmoll commented May 13, 2020

merged, bedankt @ekohl!

@ekohl ekohl deleted the fedora branch May 13, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekohl @mmoll @theforeman-bot @wbclark