Fixes #12597: remove extraneous method definition in the DNS API tests

And removed redundant validation in dns api 'delete' call
theforeman · Nov 26, 2015 · bef9bee · bef9bee
1 parent 42b9581
commit bef9bee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/modules/dns/dns_api.rb b/modules/dns/dns_api.rb
@@ -28,7 +28,6 @@ class Api < ::Sinatra::Base
     end
 
     delete "/:value" do
-      log_halt(400, "'remove' requires value parameter") if params[:value].nil?
       type = params[:value].match(/\.(in-addr|ip6)\.arpa$/) ? "PTR" : "A"
 
       begin

diff --git a/test/dns/dns_api_test.rb b/test/dns/dns_api_test.rb
@@ -78,9 +78,7 @@ def test_delete_ptr_record
   end
 
   def test_delete_returns_error_if_value_is_missing
-    def test_create_returns_error_if_type_is_missing
-      delete '/'
-      assert_equal 400, last_response.status
-    end
+    delete '/'
+    assert_equal 404, last_response.status
   end
-end
+end