fixes #8811 - refactor per-module enabling of http(s) to http(s)_rackup #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ def test_log_used_default_settings | |||
| assert_equal ':a: a, :b: b, :enabled: false', plugin.log_used_default_settings | |||
| end | |||
|
|
|||
| class TestPlugin2 < Proxy::Plugin; end | |||
| class TestPlugin2 < Proxy::Plugin; plugin :test2, '1.0'; end | |||
There was a problem hiding this comment.
can you add a test based on the real plugin definition? e.g. where the http_rackup_path is define prior to the plugin?
shlomizadok
force-pushed
the
8811
branch
2 times, most recently
from
902e282
to
1af1d9e
Compare
|
😩 [test] |
|
[test] |
|
merged as e2ce2a0 thanks @shlomizadok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved checks for http(s)_enabled? to http(s)_rackup methods