Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10940: puppetrun works properly now on ruby > 1.8.7 #307

Closed
wants to merge 1 commit into from
Closed

Fixes #10940: puppetrun works properly now on ruby > 1.8.7 #307

wants to merge 1 commit into from

Conversation

dmitri-d
Copy link
Member

@dmitri-d dmitri-d commented Aug 6, 2015

No description provided.

@domcleal
Copy link
Contributor

That's working better, but there's another issue with customrun on 1.9+, up to you if you'd like me to file it separately as it's different.

Specifying customrun_args as a string containing multiple arguments (:customrun_args: -a -b -c) doesn't work as expected on 1.9+, because they'd be passed in as a single argument to the command rather than being parsed like a shell would do (and as our code does on 1.8, since it joins the array).

It's possible to specify an array of arguments in the YAML config file, though this isn't what's documented. This would mean we need to flatten the resulting array.

@dmitri-d
Copy link
Member Author

@domcleal: this should do it.

@domcleal
Copy link
Contributor

Merged as b446e0c, thanks @witlessbird.

@domcleal domcleal closed this Aug 25, 2015
@dmitri-d dmitri-d deleted the 10940-fix-customrun branch May 24, 2016 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants