Fixes #18070 - add_record() checks for conflicts with leases now. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timogoebel: updated add_record to check for conflicts with leases. |
|
[test] |
1 similar comment
|
[test] |
timogoebel
reviewed
Jan 24, 2017
| unless similar_records.empty? | ||
| logger.warn "Request to create a conflicting DHCP record" | ||
| logger.debug "request: #{to_return.inspect}" | ||
| logger.debug "existing: #{similar_records.inspect}" |
There was a problem hiding this comment.
Too many whitespaces between : and #
| end | ||
| true | ||
| def ==(other) | ||
| ip == other.ip && mac == other.mac && subnet == other.subnet && deleteable? == other.deleteable? && options == other.options |
There was a problem hiding this comment.
Should we check if other is really a record before comparison? Same for Proxy::DHCP::Lease.
|
|
||
| validate_ip(options[:ip]) | ||
| validate_mac(options[:mac]) | ||
| raise(Proxy::DHCP::Error, "Must provide hostname") unless options[:hostname] |
There was a problem hiding this comment.
Is this safe to remove because we use "name" as a fallback? Should we add a check if name is set?
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
timogoebel
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.