Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21710 - correct arguments to find_free_ip are used. #551

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Fixes #21710 - correct arguments to find_free_ip are used. #551

merged 1 commit into from
Nov 22, 2017

Conversation

dmitri-d
Copy link
Member

No description provided.

@ares
Copy link
Member

ares commented Nov 21, 2017

rubocop is not happy about the change - http://ci.theforeman.org/job/test_proxy_develop_pr_rubocop/1126/checkstyleResult/new/

but it fixes the issue, so 👍 after fixing rubocop

@dmitri-d
Copy link
Member Author

  • fixed rubocop warnings.

@dmitri-d
Copy link
Member Author

Test failures are due to newer rack and rack-test dependencies requiring ruby >= 2.2.2. The issue is resolved in #552

@iNecas
Copy link
Member

iNecas commented Nov 22, 2017

[test]

@iNecas
Copy link
Member

iNecas commented Nov 22, 2017

[test default]

@ares
Copy link
Member

ares commented Nov 22, 2017

Thanks @witlessbird, merging!

@ares ares merged commit 09b72a0 into theforeman:develop Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready to merge
Projects
None yet
Milestone
No milestone
4 participants
@dmitri-d @ares @iNecas @theforeman-bot