Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #25100 - do not use Process::CLOCK_MONOTONIC yet #614

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Refs #25100 - do not use Process::CLOCK_MONOTONIC yet #614

merged 1 commit into from
Oct 16, 2018

Conversation

lzap
Copy link
Member

@lzap lzap commented Oct 16, 2018

This is Ruby 2.2+ only. No big deal if measured time is negative, it only goes into logs.

tbrisker
tbrisker approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lzap !

@lzap
Copy link
Member Author

lzap commented Oct 16, 2018

There is not test for these couple of lines, but I will be AFK for 2 hours now.

@tbrisker
Copy link
Member

[test core]

@tbrisker tbrisker merged commit 1cb579c into theforeman:develop Oct 16, 2018
@lzap lzap deleted the logging-monotonic-25100 branch October 16, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@lzap @tbrisker @theforeman-bot