Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #27550 - grub2 native config files #670

Merged
merged 1 commit into from Aug 8, 2019
Merged

Fixes #27550 - grub2 native config files #670

merged 1 commit into from Aug 8, 2019

Conversation

lzap
Copy link
Member

@lzap lzap commented Aug 8, 2019

See the RM issue for the reasoning. We already do this for PXELinux, this will vastly simplify how we load custom config files.

@lzap lzap mentioned this pull request Aug 8, 2019
Merged
ekohl
ekohl approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly surprising to me that pxeconfig_file returns an array of files, but that's not really something this PR should touch.

@ekohl ekohl merged commit 7d0053a into theforeman:develop Aug 8, 2019
@lzap lzap deleted the grub2-tftp-config branch August 9, 2019 08:47
@lzap
Copy link
Member Author

lzap commented Aug 9, 2019

Hehe yeah we use this already for PXELinux and iPXE too I think. It was refactored, files would be definitely better. Thanks for quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@lzap @ekohl @theforeman-bot