Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #29185 - expose TFTP via /EFI/BOOT #750

Closed
wants to merge 1 commit into from

Conversation

lzap
Copy link
Member

@lzap lzap commented Feb 28, 2020

Javier Martinez Canillas of Red Hat explained to me that grub2 from grub2-efi-x64-cdboot package expects files to be on /EFI/BOOT path and this is where we should expose them both via TFTP and HTTP. Let's change this to comply with how grub2 expects things, currently we expose the TFTP directory via /httpboot and /EFI root paths.

This patch retains backward compatibility, so a file /var/lib/tftpboot/TEST is available under three paths:

An attempt to list BOOT subdirectory fails, that's expected:

$ curl http://localhost:8448/EFI/BOOT
Invalid or empty path

@ekohl
Copy link
Member

ekohl commented Mar 1, 2020

It would be nice to have the same text as in this PR for the git commit. The history is very useful. Would it also make sense to write some integration test for this to make sure we don't break this in the future?

@lzap
Copy link
Member Author

lzap commented Mar 2, 2020

They do have the same text, or what do you mean?

We do have integration tests in httpboot_api_test.rb thing is they are written on the Sinatra App level, therefore they are all executed from the app root namespace. The patch simply adds new mapping, I don't see huge benefit in adding that.

@lzap
Copy link
Member Author

lzap commented Mar 25, 2020

Ping @ekohl

@lzap
Copy link
Member Author

lzap commented Apr 21, 2021

Rebased, I think this can be useful for non-RH/Debian Foreman users with some different (untested) grub2 builds.

@lzap
Copy link
Member Author

lzap commented Jul 4, 2022

This is still valid and should be merged.

@lzap lzap closed this Feb 19, 2023
@lzap lzap deleted the efi-boot-29185 branch February 19, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants