Fixes #35184 - Drop puppetca_puppet_cert provider #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently for Puppet 6.0 or higher the Puppetserver REST API is used. Puppet 5 is EOL so this can be dropped. Older versions (dating back to Puppet 4) had an incomplete API, but core methods do work. Just the reporting in the UI is incomplete. This means even with Puppet 5 it won't be completely broken. Dropping this allows us to move forward. The current implementation has some coding techniques which need adjustment on Ruby 3. Since nobody should be using the old code, refactoring it is pointless.
ehelms
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for Puppet 6.0 or higher the Puppetserver REST API is used. Puppet 5 is EOL so this can be dropped. Older versions (dating back to Puppet 4) had an incomplete API, but core methods do work. Just the reporting in the UI is incomplete. This means even with Puppet 5 it won't be completely broken.
Dropping this allows us to move forward. The current implementation has some coding techniques which need adjustment on Ruby 3. Since nobody should be using the old code, refactoring it is pointless.